> On Aug. 26, 2014, 5:40 p.m., Marco Martin wrote: > > src/plasma/private/packages.cpp, line 278 > > <https://git.reviewboard.kde.org/r/119942/diff/1/?file=307679#file307679line278> > > > > maybe going even more explicit and giving its own subdicrectory too? > > (i'm fine with either)
A subdirectory for one item is probably overkill, and it does make sense there imho as it is with the other applet explorer bits. The name "explorer" is perhaps a bit unfortunate, but it is not so bad as to warrant changing it. This does all need documenting, however. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/#review65294 ----------------------------------------------------------- On Aug. 26, 2014, 5:25 p.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119942/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 5:25 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Give the applet alternatives QML file an entry; this adds to the > self-documenting nature of the package and prevents paths from creeping into > usage points. This is a starting point in the package, so it should have a > well known name. > > > Diffs > ----- > > src/plasma/private/packages.cpp 585ab1f272d48f9b998c64968beeccf0f6dd979f > > Diff: https://git.reviewboard.kde.org/r/119942/diff/ > > > Testing > ------- > > Loaded plasmashell and the alternatives UI. > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
