On Sunday 17 August 2014 00:03:41 David Faure wrote: > kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers > API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, > support for trash in FileUndoManager, and I'm about to add a > KIO::restoreFromTrash job). > And KIO::trash is called from the file dialog (kdiroperator.cpp). > So this is a missing runtime dependency if kde-workspace/kio-extras isn't > installed. > > How about we move kio_trash to the kio framework? > > (If we agree, can someone do it? I still have no experience with doing this > in a way that preserves the git history)
I guess that'd also fix my CI-related issue here [1], right: QWARN : GitInitTest::testRemoveEmptyFolder() couldn't create slave: "Unable to create io-slave: klauncher said: Unknown protocol 'trash'. " (We're using KIO::trash, but the CI doesn't provide this particular slave because it's part of different module) Greets [1] http://build.kde.org/view/kdevelop/job/kdevplatform_frameworks_qt5/154/testReport/(root)/TestSuite/test_kdevgit/ -- Kevin Funk | kf...@kde.org | http://kfunk.org _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel