----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66871 -----------------------------------------------------------
I would really like to hear Aurelien's opinion, but maybe you can also explain: If a running hideAnimation is interrupted, and reversed by showing a different message, how does the widget handle the resize interruption? Will it resize smoothly during the animation? How does it handle the text change while it is visible? - Christoph Feck On Sept. 18, 2014, 10:40 a.m., Fabio D'Urso wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120160/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 10:40 a.m.) > > > Review request for KDE Frameworks, Christoph Feck and Aurélien Gâteau. > > > Repository: kwidgetsaddons > > > Description > ------- > > Hi, I've found that if you call animatedShow() immediatly after > animatedHide(), without waiting for the hide animation to finish first, the > hide animation goes on and, in the end, the message widget becomes hidden. > > The attached patch adds checks in animatedShow and animatedHide so that, if > an opposite animation is currently running, they just reverse it. > > > Diffs > ----- > > autotests/kmessagewidgetautotest.h 062e2b3 > autotests/kmessagewidgetautotest.cpp f46bab0 > src/kmessagewidget.cpp bc7ba32 > tests/kmessagewidgettest.cpp f621b5a > > Diff: https://git.reviewboard.kde.org/r/120160/diff/ > > > Testing > ------- > > I've added buttons to invoke animatedShow and animatedHide in > tests/kmessagewidget.cpp and used them to test the behavior. > > I've also added an autotest that checks the final height and isVisible() > value, both after single animatedShow/animatedHide calls and after > animatedShow+animatedHide and animatedHide+animatedShow. > > > Thanks, > > Fabio D'Urso > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
