----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ -----------------------------------------------------------
(Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Look for kdesu in libexec/kf5 If you want it to be renamed or installed some other place please comment here: https://git.reviewboard.kde.org/r/120040 I don't have a strong opion on this and will just adapt to whatever Marco decides. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description ------- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is "Could not launch 'root'" which is somewhat correct but not as easy to figure out as "Could not launch 'kdesu'" Also added an unrelated QFile::decodeName() call. Diffs (updated) ----- autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing (updated) ------- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
