> On Ott. 18, 2014, 8:10 p.m., Alex Merry wrote: > > I guess we're assuming no-one's putting double-quotes in the URIs? > > > > It's probably not worth making it more reslient, given the extra complexity > > that would entail (you'd either have to do some pre-escaping or write it > > out to a temporary file, given the lack of an INPUT_VARIABLE option to > > execute_process.
Uhm, I don't know. It's theoretically possible, I have the feeling that some other stuff would break too. Another possible solution would be to pass the value using an environment value. What do you think? And apart from this issue, what do you think of the rest of the code? - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68674 ----------------------------------------------------------- On Ott. 18, 2014, 5:50 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Ott. 18, 2014, 5:50 p.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, > and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on > kdelibs4support. > > > Diffs > ----- > > src/CMakeLists.txt 341ecf4 > cmake/uriencode.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
