----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/ -----------------------------------------------------------
(Updated Nov. 4, 2014, 3:58 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio-extras Description (updated) ------- Due to some missing XDR functions on OSX (used to decode unsigned long long), it failed to compile. This fixes that by doing some checks for the existence of the 64-bit datatype functions (for some reason XDR have 5 different functions that do the same thing). This patch also merges the mount3 rpc code with the nfs3 code as well as remove the unused rpc mount2 code. Diffs ----- nfs/rpc_mnt3.h cba4ff656a3d524f39cb7f607b8b4b331b41a0c5 nfs/rpc_mnt2_xdr.c b380f4f93853ba54112a68ddf851f8f04b251312 nfs/rpc_mnt2.x 4aaf97de9ade2655cd48ae460ba24ee322b57183 nfs/nfsv3.cpp 368a61febc778688507ffb3954caaf69fc18d371 nfs/rpc_nfs2_prot.x cd21123c7b57040d97245f22038153945abe88ee nfs/rpc_nfs2_prot.h 62ab3056a51cc0e89536081c9d5741ff136dc804 nfs/rpc_nfs3_prot_xdr.c 57f4a8546ae697f41f98efb24c01b6de739d380f nfs/rpc_nfs3_prot.x fba417c8cd6edb955e018a89dd38942f1e788c69 nfs/rpc_nfs3_prot.h 76b2f5becef9cbdc9fd3db08c540c065a43a89a6 nfs/rpc_nfs2_prot_xdr.c fb63b8ec2329730ef55c8f068e8abf47e865173b nfs/rpc_mnt3_xdr.c 2016e688770e3753affe20923a8515f2427c5447 nfs/rpc_mnt2.h ed21256c4754ce861ff1f5ea5ddc4ca224a7da7e nfs/kio_nfs.h 9943daf670e665121ea51419ea77599ec4d8d4f5 nfs/CMakeLists.txt 2ed2186e113dad9e9c178cbac680d7c96dff789a Diff: https://git.reviewboard.kde.org/r/120969/diff/ Testing ------- I haven't personally tried to compile it on OSX, but Marko Käning (the one who reported it, https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg19770.html) confirmed that it's now compiling fine on OSX. Thanks, Mathias Tillman
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
