----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70302 -----------------------------------------------------------
Since this seems quite easy to test, I would like automated tests before this gets merged (we already have too much untested code in this framework) - Àlex Fiestas On nov. 11, 2014, 2:51 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121095/ > ----------------------------------------------------------- > > (Updated nov. 11, 2014, 2:51 p.m.) > > > Review request for KDE Frameworks, David Faure and Michael Pyne. > > > Repository: frameworkintegration > > > Description > ------- > > This patch is related to /r/121094, which moves KTextToHTML conversion > utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on > KEmoticons needed for smileys conversion, I added the actual KEmoticons code > here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig > dependency for KMessageBox. > > This patch refactors the FrameworkIntegrationPlugin a bit - I split the > KMessageBox-specific code into a separate file, and added a new file with the > KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking > more and more classes into a single file :-) > > > Diffs > ----- > > CMakeLists.txt 3721bfa > src/integrationplugin/CMakeLists.txt 3395368 > src/integrationplugin/frameworkintegrationplugin.h 6dc6825 > src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d > src/integrationplugin/kmessagebox.h PRE-CREATION > src/integrationplugin/kmessagebox.cpp PRE-CREATION > src/integrationplugin/ktexttohtml.h PRE-CREATION > src/integrationplugin/ktexttohtml.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121095/diff/ > > > Testing > ------- > > Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems > to work. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
