----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 -----------------------------------------------------------
hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several *seconds* later. This way, i think it's not using the incubator at all, and i don't think it's really acceptable. In QML itself, QQuickView does internally use an incubator as well, even tough in a slightly different manner it seems. - Marco Martin On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121113/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 6:24 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > We had a while loop which processed all application events whilst we > were in the middle of creating objects. This leads to weird bugs, and > workarounds in ShellCorona. > > Qt's methods forceCompletion does not seem to have the same problems and > works just as well. > > > Diffs > ----- > > src/kdeclarative/qmlobject.cpp 029edaf > > Diff: https://git.reviewboard.kde.org/r/121113/diff/ > > > Testing > ------- > > Ran plasmashell with many panels filled with applets > > Added debug on void ShellCorona::createWaitingPanels() to make sure it was > never called with m_loading true. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
