On Thursday 13 of November 2014 16:39 Albert Astals Cid wrote: > El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va > > escriure: > > El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va > > > > escriure: > > > ++ to the idea moving it. > > > > > > Super fast review: > > > > > > in the dbus folder the are 3 files called hand_edits.diff in different > > > capitalisation. > > >
I removed them as they are not used. > > > I'm not a fan of the propertiesChanged() method making it into the > > > public > > > API which we see in most classes, it's very much an implementation > > > detail > > > for QDBusAbstractInterface being rubbish. > > Should we move it to private classes? > > As far as i understand the maintainers preferred to tie it to the nm > > releases and not to the frameworks releases. Has this changed? > > Oh man, that is what i get for email being weird and getting David answer > before Jan's email, so yes i guess this has changed :D > There is no plan to tie it with the NM releases. Having it released with the frameworks gives us opportunity to release fixes/changes more frequently. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel