----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/#review70672 -----------------------------------------------------------
+1 looks good to me. - Aleix Pol Gonzalez On Nov. 19, 2014, 11:42 p.m., Teemu Rytilahti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121181/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:42 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kde-cli-tools > > > Description > ------- > > This oneliner makes kcmshell to return -1 when no module was found. This is > useful to get feedback whether a module was launched or not on systems > shipping both kcmshell4 and kcmshell5. For example digikam is using kcmshell4 > to launch colors KCM, which is only launchable through kcmshell5 on systems > running the KF5 desktop. > > A better approach would be nice to have though as kcmshell may not be > available on all platforms. Tried KServiceTypeTrader to load the module and > embedded it into a custom dialog, but as the module is available only from > kf5's ksycoca that doesn't work.. > > > Diffs > ----- > > kcmshell/main.cpp 7d0ec1a > > Diff: https://git.reviewboard.kde.org/r/121181/diff/ > > > Testing > ------- > > > Thanks, > > Teemu Rytilahti > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
