----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71519 -----------------------------------------------------------
As background: I was the one who added this icon in KDE4 times. I changed the title to be bold and added the icon, which later became the KTitleWidget we know today. The icon in KPageWidget indeed does not have any functionality, I added this simply I personally thought this looked good. But it's not required at all, so I'd be fine with removing it in KF5. Other reviews welcome. - Dominik Haumann On Dec. 7, 2014, 10:49 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121379/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 10:49 a.m.) > > > Review request for KDE Frameworks, Christoph Feck and Dominik Haumann. > > > Repository: kwidgetsaddons > > > Description > ------- > > As mentioned in [KPageView/KTitleWidget: Remove top right > icon](https://forum.kde.org/viewtopic.php?f=285&t=123837) the top-right icon > serves no visible purpose and can even be a distraction. This patch removes > the code that adds the icon. > > > Diffs > ----- > > src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1 > > Diff: https://git.reviewboard.kde.org/r/121379/diff/ > > > Testing > ------- > > Screenshots: > http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch) > http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after) > http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch) > http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after) > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel