----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/#review71854 -----------------------------------------------------------
src/core/global.cpp <https://git.reviewboard.kde.org/r/121461/#comment50069> std::all_of() maybe? std::all_of(basename.cbegin(), basename.cend(), [](QChar c) { return c == QLatin1Char('.'); }); - Emmanuel Pescosta On Dec. 12, 2014, 11:56 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121461/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 11:56 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 341773 > https://bugs.kde.org/show_bug.cgi?id=341773 > > > Repository: kio > > > Description > ------- > > 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains > dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the > extension. > 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, > instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't > be changing that. > > > Diffs > ----- > > autotests/globaltest.cpp 06cb500 > src/core/global.cpp f18ac10 > > Diff: https://git.reviewboard.kde.org/r/121461/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
