----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/#review73047 -----------------------------------------------------------
Ship it! Looks good to me, except you removed the r on the end of parser in the comment :) - Jeremy Whiting On Jan. 3, 2015, 2:36 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121792/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2015, 2:36 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > It's something we used to do somewhere in kdelibs4 so people don't expect > them to have to call this stuff manually. Also gives us some consistency. > > > Diffs > ----- > > src/lib/kaboutdata.h 5564dab > src/lib/kaboutdata.cpp f8d5e30 > > Diff: https://git.reviewboard.kde.org/r/121792/diff/ > > > Testing > ------- > > Ran one of my apps, now i have help and version. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel