----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105/#review74180 -----------------------------------------------------------
Ship it! Ship It! - Jeremy Whiting On Jan. 17, 2015, 4:53 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122105/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 4:53 a.m.) > > > Review request for KDE Frameworks and KDE Games. > > > Repository: libkdegames > > > Description > ------- > > Since you can't use KSharedConfig::openConfig from a static destructor > anymore (the QCoreApplication is gone and thus can't find the name of the > thing) use a post routine to save the level before the QCoreApplication is > gone. > > KF5 people: Is this something worth mentioning on the porting notes or using > KSharedConfig::openConfig from a static destructor is a bit of a corner case > anyway? > > > Diffs > ----- > > kgdifficulty.cpp 94489c7 > > Diff: https://git.reviewboard.kde.org/r/122105/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
