----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122149/#review74347 -----------------------------------------------------------
That's one option, and a good one for compat. The other option is to change the callers to pass a single dash instead, then Qt will process such options automatically - right? - David Faure On Jan. 19, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122149/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 3:21 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kde-cli-tools > > > Description > ------- > > KCmdLineArgs used to define many arguments. In this case it was using --icon > and --caption. At the moment, since we don't have these options we are > getting warnings such as: > kcmshell5(19712)/(default) QCommandLineParserPrivate::aliases: > QCommandLineParser: option not defined: "caption" > kcmshell5(19712)/(default) QCommandLineParserPrivate::aliases: > QCommandLineParser: option not defined: "icon" > > This patch addresses this by adding them explicitly in here. I'm unsure if we > want to do any further engineering or that's good enough. > > > Diffs > ----- > > kcmshell/main.cpp 98e646b > > Diff: https://git.reviewboard.kde.org/r/122149/diff/ > > > Testing > ------- > > Ran it again, now it doesn't complain. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel