> On Jan. 7, 2015, 6:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > <https://git.reviewboard.kde.org/r/121903/diff/1/?file=338977#file338977line12> > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CONF > > QT_LOGGING_RULES > > > > This will block all of the other methods from working. I don't think we > > can really do that. > > > > I'd prefer making a template qtlogging.ini if the file doesn't exist; > > as that still allows apps to override libs on/off if they prefer and allows > > people to set a logging_conf if they prefer. > > Aleix Pol Gonzalez wrote: > I'm unsure how to do that. Ideas? > > Martin Klapetek wrote: > Maybe just replace it with > QLoggingCategory::setFilterRules(*.debug=false) in main? That still gives > QT_LOGGING_CONF and QT_LOGGING_RULES to overwrite it. > > Aleix Pol Gonzalez wrote: > That's what I wanted to do initially, but then with this we still only do > it for plasmashell. I think it's good to have it elsewhere as well (thinking > about kded mainly). > > Martin Gräßlin wrote: > can't we ship a kconf update script to modify qtlogging.ini?
Pushed to davidedmundson/defaultloggingrules my kconf_update script wasn't being run properly and I never figured out why. Shell script part is fine though. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903/#review73399 ----------------------------------------------------------- On Jan. 7, 2015, 5:57 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121903/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 5:57 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > At the moment we are having a very ugly setting in plasmashell called > "--shut-up" to filter output by default. This patch tries to address that by > defining, in startkde, by default: > ```QT_LOGGING_RULES="*.debug=false"``` > > This filters out all q*Debug calls. It's better because it won't filter > warnings so they can be read from .xsession-errors in case we need to debug > things (at the moment it was useless because we were filtering everything) > and it will also work for other processes, which can also come in handy. > > Developers might want to ```unset QT_LOGGING_RULES``` after this > > > Diffs > ----- > > shell/main.cpp 005f908 > startkde/startkde.cmake 046543e > > Diff: https://git.reviewboard.kde.org/r/121903/diff/ > > > Testing > ------- > > Log out + log in seemed to work after the changes, I'm unsure how to test, > especially the startkde part. Should be quite straightforward though. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
