----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review74633 -----------------------------------------------------------
Ship it! Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most certainly consistent. (see e.g. kcoreaddons - the find_package(Qt5Test) is being done in the autotests subfolder, the same could be done here). - David Faure On Jan. 22, 2015, 7:48 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122206/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 7:48 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > [kio] Make tests optional > This is a small patch to CMakeLists.txt to only depend on Qt5Test if > BUILD_TESTING. > > > Diffs > ----- > > CMakeLists.txt 7fe0be5d4b2d7d9475a7844b4f8d93fc2f0a00c3 > > Diff: https://git.reviewboard.kde.org/r/122206/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sturmlechner > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
