----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122495/ -----------------------------------------------------------
Review request for KDE Frameworks and Friedrich W. H. Kossebau. Repository: kdiagram Description ------- Mark Qt5::Widgets public for both KCharts and KGantt. Remove SHARED from add_library, let cmake use the default (which is SHARED, but the user can configure). Fix some indentation. Remove redundant dependencies: if we depend on Qt5::Widgets, we're already pulling Qt5::Gui. Diffs ----- src/KChart/CMakeLists.txt 06f3846 src/KGantt/CMakeLists.txt 25d198f CMakeLists.txt 76a7c50 Diff: https://git.reviewboard.kde.org/r/122495/diff/ Testing ------- Still builds. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
