> On Feb. 9, 2015, 7:24 p.m., David Faure wrote: > > This should not be done if the slave has provided a UDS_MIME_TYPE. E.g. > > kio_smb sends mimetypes that derive from inode/directory, such as > > application/x-smb-server and application/x-smb-workgroup. If you think this > > works with the current patch, please prove it with a unittest :-) > > Àlex Fiestas wrote: > I quite not get this message sorry :/ can you explain a bit more? > > Àlex Fiestas wrote: > Mmm I think I get it now, will check it out (write the test) tomorrow.
Added tests for the use case you suggest (I think) they pass without modification to the patch. The reason why they patch is that UDS_MIME_TYPE is used in the ctor of the private class, so the added code will not we called in that case since mimetype is already initialized. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review75730 ----------------------------------------------------------- On Feb. 15, 2015, 6:27 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121447/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2015, 6:27 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > If we know that the item is a dir, return directly the correct mimetype for > directories. > > More info of why this is needed at: > https://git.reviewboard.kde.org/r/120909/ > > > Diffs > ----- > > autotests/kfileitemtest.h 0ee7204 > autotests/kfileitemtest.cpp 59c104e > src/core/kfileitem.cpp 5894226 > > Diff: https://git.reviewboard.kde.org/r/121447/diff/ > > > Testing > ------- > > Besides tests, tried smb kioslave and it worked great. > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
