> On feb. 16, 2015, 10:28 p.m., Albert Astals Cid wrote: > > You're missing lots of const in your getters and const & in your params > > Gregor Mi wrote: > Thx for the hint, I added now lots of const in the getters. > With "const & in params" are referring to QString parameters? I thought > they were reference counted.
I'm referring to any not POD type. Yes, QString is reference counted, but increasing the refcount is still more expensive than just const & it - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76158 ----------------------------------------------------------- On feb. 16, 2015, 10:36 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122576/ > ----------------------------------------------------------- > > (Updated feb. 16, 2015, 10:36 p.m.) > > > Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. > > > Repository: kservice > > > Description > ------- > > Usage examples see https://git.reviewboard.kde.org/r/122352/ and > https://git.reviewboard.kde.org/r/122374/ > > Description see class comments on KMoreTools and > https://community.kde.org/Scratchpad/KMoreToolsFramework > > If KMoreTools is considered useful it needs a home. I placed it in KService > for now. > > > Diffs > ----- > > tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e > tests/kmoretools/1/a.desktop PRE-CREATION > tests/kmoretools/1/b.desktop PRE-CREATION > tests/kmoretools/1/c.desktop PRE-CREATION > tests/kmoretools/2/kate.desktop PRE-CREATION > tests/kmoretools/2/kate.png PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION > tests/kmoretools/kmoretoolstest.cpp PRE-CREATION > CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 > src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 > src/kmoretools/kmoretools.h PRE-CREATION > src/kmoretools/kmoretools.cpp PRE-CREATION > src/kmoretools/kmoretools_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION > src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122576/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel