> On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote: > > Ship It! > > Luigi Toscano wrote: > Please fix the extracted pot so that it is called <file>_qt.pot. > > (personally speaking, I would strongly suggest lxde to use ki18n, but > that's another discussion) > > Luigi Toscano wrote: > Sorry, there is also another change about the script used, check other > tier1 frameworks > > Jerome Leclanche wrote: > I don't understand what you're asking of me - in the last diff, I'm not > touching the pot file at all. > > Luigi Toscano wrote: > Sorry again, it' s a bit.more complicated as there is already such > _qt.pot file (the main one). So probably it should be extended to extract > also runtime translations and the appropriate changes to translations domain > applied here. Please cc i18n, I can't do a complete check now. > > Luigi Toscano wrote: > wrt why I'm asking: the Messages.sh, maybe the top-level one and few > cmake calls to be changed to have translations working. Plase add i18n group. > > Hrvoje Senjan wrote: > i'd like to mention that translations for the daemon aren't working > anyway with 5.7.0 tar, as they aren't wrapped with ki18n macro, but with > ECMPoQmTools
@Hrvoje, the daemon is using i18n just fine in 5.7.0, ecmpoqmtools is for the library which uses .po. @Jerome, yes this change is incomplete, you either need to remove the Messages.sh in the daemon and add the ecm loading of the existing kglobalaccel5_qt qm to the daemon or create two different catalogs, i'd say having just one probably makes sense. You won't need -DTRANSLATION_DOMAIN anymore since that's for ki18n - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76863 ----------------------------------------------------------- On mar. 2, 2015, 9 a.m., Jerome Leclanche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122680/ > ----------------------------------------------------------- > > (Updated mar. 2, 2015, 9 a.m.) > > > Review request for KDE Frameworks, Localization and Translation (l10n), > Martin Gräßlin, and Martin Klapetek. > > > Repository: kglobalaccel > > > Description > ------- > > Remove the runtime's KAboutData > > The about data was unexposed, but created a dependency on KCoreAddons (for > KAboutData) and in turn on KI18n for the translations of the aboutData. > > This removes both dependencies as well as the string extraction scripts. > > -- > > Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would > like to, however it currently has too many dependencies. See > https://github.com/lxde/lxqt/issues/507 for related discussion. > I'm unsure myself if the about data is actually exposed somewhere I completely > missed, but it doesn't look that way. > > > Diffs > ----- > > CMakeLists.txt 68ad795 > src/runtime/CMakeLists.txt e639fa5 > src/runtime/globalshortcutsregistry.cpp 3e4d720 > src/runtime/kglobalacceld.cpp 4e7cb9d > src/runtime/main.cpp fdf4d62 > > Diff: https://git.reviewboard.kde.org/r/122680/diff/ > > > Testing > ------- > > Compiles and runs. No further testing done. > > > Thanks, > > Jerome Leclanche > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
