> On March 6, 2015, 12:10 a.m., Luigi Toscano wrote: > > I'm not exactly a cmake expert, is it about the exported symbols of > > KDocTools? > > Aleix Pol Gonzalez wrote: > It's not needed, it's mainly so that when a project is compiled, you > still know what include directories to use.
afaics, find_dependancy is in case when you want to use libMagic, and libMagic uses publicly (in e.g. functions/symbols or headers) libPotion. either the linking or the build due to missing includes will fail if you don't have libPotion's development files present. this is not the case if e.g. libWell is used by libMagic but privately (as implementation detail). so as distrubutor of libMagic, you don't care if your consumers have libWell devel files present or not... - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122832/#review77070 ----------------------------------------------------------- On March 6, 2015, 3:40 a.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122832/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 3:40 a.m.) > > > Review request for KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > only Qt5::Core is public, so let the config searches only them > > > Diffs > ----- > > KF5DocToolsConfig.cmake.in 6f44fc1 > > Diff: https://git.reviewboard.kde.org/r/122832/diff/ > > > Testing > ------- > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
