> On March 7, 2015, 9:42 a.m., David Faure wrote: > > src/ioslaves/http/http.cpp, line 854 > > <https://git.reviewboard.kde.org/r/122614/diff/1/?file=350094#file350094line854> > > > > I don't like the use of section, when we have QUrl API to do this > > cleanly. > > > > Store thisURL.adjusted(StripTrailingSlash), and use fileName() on that?
Heh ok race condition ;) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/#review77150 ----------------------------------------------------------- On March 7, 2015, 9:29 a.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122614/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 9:29 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Fix the file/directory name extraction + base dir handling in the http ioslave > > "name" was always empty for directories because thisURL ends with a slash and > fileName() will return an empty string, so href.text() was used as UDS_NAME > instead. > > > Diffs > ----- > > src/ioslaves/http/http.cpp 78f50f9 > > Diff: https://git.reviewboard.kde.org/r/122614/diff/ > > > Testing > ------- > > Works (see screenshots) > > > File Attachments > ---------------- > > Webdav (Bug) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png > Webdav (Fixed) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png > > > Thanks, > > Emmanuel Pescosta > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
