-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122876/
-----------------------------------------------------------
Review request for KDE Frameworks and Eike Hein.
Bugs: 344903
https://bugs.kde.org/show_bug.cgi?id=344903
Repository: knotifications
Description
-------
Currently when something is started right after login and spawns a
notification, an ugly popup (KPassivePopup fallback) will appear over the
splash screen as the org.freedesktop.Notifications service is not ready yet.
This patch delays the notifications by max 25 seconds if and only if
KDE_FULL_SESSION is set and there's no Plasma (org.kde.plasmashell) running. If
the org.freedesktop.Notifications does not appear within those 25 seconds, the
notifications will be put on screen using KPassivePopup.
Ideally this should also check if ksmserver is in the "starting phase", but I
haven't found a way to check for that. Suggestions welcome.
Diffs
-----
src/notifybypopup.h 416c533
src/notifybypopup.cpp 316ff2b
Diff: https://git.reviewboard.kde.org/r/122876/diff/
Testing
-------
Plasma not running, emitted KNotification, nothing, started Plasma,
notifications appeared when Plasma loaded.
Thanks,
Martin Klapetek
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
