----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ -----------------------------------------------------------
(Updated mar. 12, 2015, 4:37 a.m.) Review request for KDE Frameworks and Martin Klapetek. Changes ------- Had to remove a default empty QPixmap parameter from a different event() header, that would make a call to one of them ambiguous. This means that when recompiling an app that used event() with StandardEvent and didn't specify an icon, it will now pick the version that uses standard icons instead of the one that shows no icon at all. (Which seems ok to me). Repository: knotifications Description ------- Added an event() version that takes no icon and will use a default one depending on the notification type Diffs (updated) ----- src/knotification.h f2dcd74e26a4feefe53dc0e536b0178d5ce287e1 src/knotification.cpp 293de09bae8d16b77df81ee2fe447c3246a476b5 Diff: https://git.reviewboard.kde.org/r/122913/diff/ Testing ------- Thanks, Albert Vaca Cintora
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
