> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 394 > > <https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394> > > > > Do we need the kmt-prefix? Why not just > > KMoreToolsService * service();
I am not completely that happy with it either. The reason behind the prefix is that there is a difference between the provided/suggested/registered service (KMoreToolsService*) and the acutally installed service (KService*). So one solution to this naming issue could be to consistently use the term "suggested service" (or better "registered service"? Other idea?). > On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 429 > > <https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line429> > > > > Too many todo's in the code, commented out code and also the comments. > > > > So I consider this as work in progress, right? Yes. But partially they are present because I need some directions. So, I'll process your opened issues and I will create my own ones for specific questions where a second opinion would be nice. - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77502 ----------------------------------------------------------- On March 11, 2015, 11:06 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122910/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 11:06 p.m.) > > > Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here > (knewstuff). > > Example usages: > - dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/ > - kate's project addin: https://git.reviewboard.kde.org/r/122374/ > > > Diffs > ----- > > src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 > src/kmoretools/kmoretools.h PRE-CREATION > src/kmoretools/kmoretools.cpp PRE-CREATION > src/kmoretools/kmoretools_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION > src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION > src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION > tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb > tests/kmoretools/1/a.desktop PRE-CREATION > tests/kmoretools/1/b.desktop PRE-CREATION > tests/kmoretools/1/c.desktop PRE-CREATION > tests/kmoretools/2/kate.desktop PRE-CREATION > tests/kmoretools/2/kate.png PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION > tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION > tests/kmoretools/kmoretoolstest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122910/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel