----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123178/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kcompletion Description ------- The deleted condition checks whether completionMode is different to KCompletion::CompletionNone. This condition is inside another condition that checks the same. Therefore it's useless. Besides, at the beginning of the method there are multiple else if conditions that aren't actually related (they are independent and each one ends with a "return"). Therefore, I have cleaned up the elses and left the ifs. I think that way the method is cleaner and more readable (as readable as it can be, given the length of it and the number of conditions). Diffs ----- src/klineedit.cpp 7c2d0f9 Diff: https://git.reviewboard.kde.org/r/123178/diff/ Testing ------- Tests pass Thanks, David Gil Oliva
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
