> On April 14, 2015, 3:50 p.m., Lamarque Souza wrote: > > src/notifybyaudio.cpp, line 89 > > <https://git.reviewboard.kde.org/r/123360/diff/1/?file=361076#file361076line89> > > > > Should not this patch be followed by another patch that set LoopSound > > flag for Persistant notifications that *really* want sound to loop? This > > change can be considered a regression if such a persistant notification > > exists. > > Martin Klapetek wrote: > I'm not aware of any such notification (also note that this code was > written from scratch for frameworks only). The only place I know I will use > it is ktp-call-ui but I really don't see why should that patch be posted here > as a follow-up...
That is fair, no more issues from my side then. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78923 ----------------------------------------------------------- On April 14, 2015, 2:41 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123360/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 2:41 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 346148 > https://bugs.kde.org/show_bug.cgi?id=346148 > > > Repository: knotifications > > > Description > ------- > > Some notifications might want to loop the sound, eg. calling apps playing the > ringing sound which is not wanted to play once. Currently the sound is looped > for all persistent notifications, but that's not ideal as not all persistent > notifications with sound want/need sound looping. This new LoopSound flag > solves that. > > > Diffs > ----- > > src/knotification.h 8efd92a > src/notifybyaudio.cpp ee3ef1e > > Diff: https://git.reviewboard.kde.org/r/123360/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
