> On abr. 24, 2015, 3:21 p.m., Kevin Funk wrote: > > Hm, this could cause problems in the case where you generate multiple .pri > > files which depend on each other within one project. Problem .pri files are > > not yet installed, thus the QT modules are not yet available. > > > > I suggest trying this patch on sonnet, where SonnetUi depends on > > SonnetCore. Both generate a .pri file, too. > > And if I'm not mistaking I just spotted that the .pri file for SonnetUi > > doesn't have SonnetCore in its dependency list... => Bug? :)
Aren't basically our tests designed to be run after install? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79454 ----------------------------------------------------------- On abr. 24, 2015, 3:26 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123491/ > ----------------------------------------------------------- > > (Updated abr. 24, 2015, 3:26 p.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk. > > > Repository: extra-cmake-modules > > > Description > ------- > > Do some sanity checking on the dependencies we're declaring > > > Diffs > ----- > > modules/ECMGeneratePriFile.cmake af4b877 > > Diff: https://git.reviewboard.kde.org/r/123491/diff/ > > > Testing > ------- > > Ran make test in ktextwidgets without > http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 > and it correctly failed. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
