> On April 28, 2015, 2:35 p.m., David Faure wrote: > > src/core/global.cpp, line 407 > > <https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407> > > > > startsWith('.') (using the QChar overload) > > > > Do we even need this special case, with the way the code is now? It > > seems to me that removing this first if() branch would work just the same.
The first if() has been used for getting ". (1).txt" instead of ".txt (1)" - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79629 ----------------------------------------------------------- On April 30, 2015, 9:05 a.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123224/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 9:05 a.m.) > > > Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. > > > Bugs: 341773 > https://bugs.kde.org/show_bug.cgi?id=341773 > > > Repository: kio > > > Description > ------- > > For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong > name(something like filename-1 2.6.tar.gz). > Expected name: filename-1.6 (1).tar.gz > > > Diffs > ----- > > autotests/globaltest.cpp ff8725d > src/core/global.cpp f18ac10 > > Diff: https://git.reviewboard.kde.org/r/123224/diff/ > > > Testing > ------- > > Works fine! > > > Thanks, > > Ashish Bansal > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel