----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80075 -----------------------------------------------------------
src/kselectionproxymodel.cpp (line 2501) <https://git.reviewboard.kde.org/r/123679/#comment54938> this should be adapted as well to say connect(d->m_selectionModel.data(), &QItemSelectionModel::modelChanged, this, handleSelectionModelModel); otherwise you'll leak the lambda connection even when this is destroyed, leading to undefined behavior. - Milian Wolff On May 7, 2015, 11:31 p.m., Jan Kundrát wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123679/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 11:31 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kitemmodels > > > Description > ------- > > Turns out that there's apparently no overload accepting a QPointer as > the first argument. > > This is on Gentoo with qtbase e374ffc29c67493a51527117b55a53dfa5dd4267 > and GCC 4.8.3. > > > Diffs > ----- > > src/kselectionproxymodel.cpp 0755fb1ca527dde8287ba2607d915a4e18c20134 > > Diff: https://git.reviewboard.kde.org/r/123679/diff/ > > > Testing > ------- > > > Thanks, > > Jan Kundrát > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel