----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80164 -----------------------------------------------------------
src/kmainwindow.cpp (line 122) <https://git.reviewboard.kde.org/r/123706/#comment55008> If you keep this (see below), then use ctor initialization syntax : initial(true) { ... } src/kmainwindow.cpp (line 151) <https://git.reviewboard.kde.org/r/123706/#comment55009> It does that, but on X11 only, and to "perform an initial checkpoint". Why not actually honour the request and save settings as requested? I guess it's useful in case the app crashes. Why does saving here orphan session files? Would QSessionManager::setDiscardCommand() help? - David Faure On May 10, 2015, 10:15 a.m., Stefan Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123706/ > ----------------------------------------------------------- > > (Updated May 10, 2015, 10:15 a.m.) > > > Review request for KDE Frameworks and Rex Dieter. > > > Bugs: 346768 > https://bugs.kde.org/show_bug.cgi?id=346768 > > > Repository: kxmlgui > > > Description > ------- > > Get a KConfig object that corresponds to the QSessionManager object that is > passed in with the saveStateRequest signal. > > To make sure that the data is stored to disk we have to call sync() on the > object after the application has updated it. As the session manager always > emits a saveStateRequest after starting the application we need to skip the > sync() for the first request and instead mark it as clean. > > > Diffs > ----- > > src/kmainwindow.cpp 15eecb7 > src/kmainwindow_p.h 8204ce1 > > Diff: https://git.reviewboard.kde.org/r/123706/diff/ > > > Testing > ------- > > On F22 with kwrite & konsole > > > Thanks, > > Stefan Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel