----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/#review80217 -----------------------------------------------------------
Ship it! Ship It! - David Faure On May 11, 2015, 7:58 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123720/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 7:58 a.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > The kfiledialog_unittest was broken by me (sorry). > > The kdirselectdialog_unittest timeouts because it shows warning message > "Cannot list smb:/", probably because smb slave is not available. > Changing it to trash slave (part of frameworks/kio) fixes the warning message > and makes the test pass. > > > Diffs > ----- > > autotests/kdirselectdialog_unittest.cpp bbbc958 > autotests/kfiledialog_unittest.cpp 30392bf > > Diff: https://git.reviewboard.kde.org/r/123720/diff/ > > > Testing > ------- > > All tests now pass > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel