----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 -----------------------------------------------------------
Can you make the diff against the branch root instead of origin/master? There's some unrelated stuff there... - Aleix Pol Gonzalez On May 12, 2015, 5:22 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123735/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:22 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > to make easier doing applications like plasma that use a lot of qml to have a > single engine make a subclass of QmlObject called QmlObjectSharedEngine that > has a single, static QQmlEngine > > > Diffs > ----- > > CMakeLists.txt e6155e2 > src/kdeclarative/CMakeLists.txt d73bff0 > src/kdeclarative/kdeclarative.cpp b3906e2 > src/kdeclarative/qmlobject.h f26b67d > src/kdeclarative/qmlobject.cpp c788943 > src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION > src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/clipboard.h 980ce54 > src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 > tests/helloworld/metadata.desktop dd188c7 > tests/helloworldnowindow/metadata.desktop 15d8783 > > Diff: https://git.reviewboard.kde.org/r/123735/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel