> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: > > src/notifybypopup.cpp, line 298 > > <https://git.reviewboard.kde.org/r/123838/diff/1/?file=369884#file369884line298> > > > > I fear that's now most likely no longer the same. I assume that > > QDesktopWidget::availableGeometry() is the combination of all screens, > > while QScreen::availableGeometry() is for one screen. > > Aleix Pol Gonzalez wrote: > Yes, now it will put it properly in the center-top of the primary screen > instead of all workspaces.
Yup, exactly. However I'm thinking about actually changing it to bottom-left by default, just like normal notifications do. There's really little to no reason why it should be center-top (especially since it's notification fallback). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/#review80591 ----------------------------------------------------------- On May 18, 2015, 6:38 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123838/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 6:38 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > As summary > > > Diffs > ----- > > src/notifybypopup.cpp 8975121d546fbaa0c3f4d930b4d65f765905d313 > > Diff: https://git.reviewboard.kde.org/r/123838/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
