On 18 June 2015 at 14:50, Jeremy Whiting <jpwhit...@kde.org> wrote: > Jaroslaw, > > On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek <stan...@kde.org> wrote: >> Hi >> If you look at apps ported to KF5, KAboutData::setApplicationData() is >> used but there are also redundant lines in main(), at least these: >> >> app.setApplicationName(aboutData.componentName()); >> app.setApplicationDisplayName(aboutData.displayName()); >> app.setOrganizationDomain(aboutData.organizationDomain()); >> app.setApplicationVersion(aboutData.version()); >> >> Note, this is already performed by KAboutData::setApplicationData(). > > That may be, but if using QApplication instead of KApplication they > are needed. See the note at > https://community.kde.org/Frameworks/Porting_Notes#Application
Hi Jeremy, KAboutData::setApplicationData() works with any QCoreApplication. What I meant is to recommend calling it in main() instead of placing the app.* calls when KApplication isn't used. I don't use KApplication already and quite a few of the apps listed by lxr do not but they still have the app.* calls, indeed maybe because of the porting notes. > Maybe KAboutData::setApplicationData is not needed anymore instead or can > get it's names and other values from QApplication's accessors? The current way looks cleaner to me, KAboutData is a nice data structure. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel