> On June 18, 2015, 5:56 p.m., David Edmundson wrote: > > src/kplotwidget.h, line 190 > > <https://git.reviewboard.kde.org/r/124121/diff/1/?file=380403#file380403line190> > > > > might be good to explain that KPlotWidget will take ownership (unless > > set otherwise)
Hehe, yeah, I added that then I removed it, the class documentation mentionning this already. But I agree, I'll add it here again and mention setAutoDelete in both places. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/#review81558 ----------------------------------------------------------- On June 18, 2015, 9:59 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124121/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 9:59 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kplotting > > > Description > ------- > > KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in > replacePlotObject > > > Diffs > ----- > > src/kplotwidget.h e5b3e16b31d6d34b7c544df42531f2f91105830d > src/kplotwidget.cpp 8dcc4ecef798a53376dd8cc4a0a6e6c1804db593 > > Diff: https://git.reviewboard.kde.org/r/124121/diff/ > > > Testing > ------- > > (Not trivial to unittest because KPlotObject is not a QObject.) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel