----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81700 -----------------------------------------------------------
src/kstatusnotifieritem.h (line 413) <https://git.reviewboard.kde.org/r/124155/#comment56014> Add @since ... src/kstatusnotifieritem.h (line 414) <https://git.reviewboard.kde.org/r/124155/#comment56015> The function isn't const, but it looks like it could be. QAction *action(const QString &name) const; src/kstatusnotifieritem.cpp (line 477) <https://git.reviewboard.kde.org/r/124155/#comment56016> ... &name) const Just minor nitpicks. - Mark Gaiser On jun 23, 2015, 10:16 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124155/ > ----------------------------------------------------------- > > (Updated jun 23, 2015, 10:16 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 349513 > https://bugs.kde.org/show_bug.cgi?id=349513 > > > Repository: knotifications > > > Description > ------- > > Apparently this got removed while porting; the code allows to set custom > action by name and remove too, no reason why it shouldn't allow retrieving it > by the name. > > > Diffs > ----- > > src/kstatusnotifieritem.h 04102d1 > src/kstatusnotifieritem.cpp 4fd2fda > > Diff: https://git.reviewboard.kde.org/r/124155/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel