----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81718 -----------------------------------------------------------
Ship it! Ok, looks good to me. Minor nitpick below :) autotests/krearrangecolumnsproxymodeltest.cpp (line 90) <https://git.reviewboard.kde.org/r/124156/#comment56037> empty line can be removed between the comment and the QCOMPARE... - Mark Gaiser On jun 23, 2015, 9:33 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124156/ > ----------------------------------------------------------- > > (Updated jun 23, 2015, 9:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kitemmodels > > > Description > ------- > > It supports reordering and hiding columns from the source model. > > > Diffs > ----- > > autotests/CMakeLists.txt 4e604eeb6bd64529ec1fba983e3f58e2f8d0bd2c > autotests/krearrangecolumnsproxymodeltest.cpp PRE-CREATION > autotests/test_model_helpers.h PRE-CREATION > src/CMakeLists.txt dc7d5f04c650f8d21784f16f8d7676e5c74c93e1 > src/krearrangecolumnsproxymodel.h PRE-CREATION > src/krearrangecolumnsproxymodel.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124156/diff/ > > > Testing > ------- > > Wrote it for a customer who allowed me to keep copyright and publish it under > the LGPL. > > Unit-tested, and used in two real projects. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel