----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81896 -----------------------------------------------------------
+1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen that used for that purpose, just "incognito mode", or "new window" in applications like Konsole. src/gui/kstandardshortcut.h (line 372) <https://git.reviewboard.kde.org/r/124213/#comment56244> Isn't Ctrl+Tab usually next tab? - Kai Uwe Broulik On Juni 30, 2015, 9:13 vorm., Simon Persson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124213/ > ----------------------------------------------------------- > > (Updated Juni 30, 2015, 9:13 vorm.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > QKeySequence already has AddTab as a standard shortcut, but it was missing in > KStandardShortcut. Main problem with this is that users could not configure > the shortcut globally. This is of course only a first step, applications > would have to be updated to use this also. > Since QKeySequence uses Ctrl+Shift+N and Ctrl+T for this action when running > on KDE, this patch just goes with that as the chosen default. > Also fixes documentation error for tabNext and tabPrev that I happened to > notice. > > > Diffs > ----- > > src/gui/kstandardshortcut.h 5bb07fb > src/gui/kstandardshortcut.cpp 8400737 > > Diff: https://git.reviewboard.kde.org/r/124213/diff/ > > > Testing > ------- > > Compiles, test suite ok. > > > Thanks, > > Simon Persson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
