> On Juni 30, 2015, 4:59 nachm., Aleix Pol Gonzalez wrote: > > In general, I like it. > > > > Maybe now that we're putting the files in separate directories, we can drop > > the _mac postfixes?
I like the idea, but that won't be possible for all cases. E.g. with kkeyserver_foo it's still needed as they also get installed. Also with the private headers it might be tricky (I have another patch on top of that one to change to a plugin architecture and e.g. kwindowsystem_p_x11.h needs to include kwindowsystem_p.h). I'll have a look on it in my on top of this patch for the plugins what can be done. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/#review81902 ----------------------------------------------------------- On Juni 30, 2015, 8:19 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124212/ > ----------------------------------------------------------- > > (Updated Juni 30, 2015, 8:19 vorm.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > In the src directory we introduce a platforms directory with a specific > * osx > * wayland > * windows > * xcb > > sub directory. The platform specific source and header files are moved > into those directories. > > This is a preparation step to move the platform specific behavior into > plugins which get loaded at runtime. Such a change is required to > support more platforms in future for which kwindowsystem cannot provide > support directly. An example is proper Wayland support on the Plasma > platform. It needs to provide its own implementationn which has to > differ from the generic Wayland implementation. > > > Diffs > ----- > > src/kxutils_p.h > src/netwm.h > src/netwm.cpp > src/netwm_p.h > src/platforms/CMakeLists.txt PRE-CREATION > src/platforms/osx/CMakeLists.txt PRE-CREATION > src/platforms/wayland/CMakeLists.txt PRE-CREATION > src/platforms/windows/CMakeLists.txt PRE-CREATION > src/platforms/xcb/CMakeLists.txt PRE-CREATION > src/kxutils.cpp > src/kxmessages.h > src/kxmessages.cpp > src/kxerrorhandler_p.h > src/kxerrorhandler.cpp > src/kwindowsystem_win.cpp > src/kwindowsystem_x11.cpp > src/kselectionowner.cpp > src/kselectionowner.h > src/kmanagerselection.h > src/kkeyserver_x11.cpp > src/kkeyserver_win.cpp > src/kkeyserver_x11.h > src/kkeyserver_win.h > src/kkeyserver_mac.cpp > src/fixx11h.h > src/kkeyserver_mac.h > src/CMakeLists.txt ff2ce392ecd7969eb94543528c7a670ea0fcd870 > autotests/CMakeLists.txt dda0af259b292ee5e526bb9166811fc1b376f388 > src/kwindowsystem_wayland.cpp > src/kwindowsystem_p_x11.h > src/kwindowsystem_p_wayland.h > src/kwindowsystem_mac.cpp > src/kwindowsystem.cpp 789132e1b4883dd54218d29af9710dedfe6218e1 > src/kwindowinfo_x11.cpp > src/kwindowinfo_p_x11.h > src/kwindowinfo_win.cpp > src/kwindowinfo_mac_p.h > src/kwindowinfo_mac.cpp > src/kselectionwatcher.cpp > src/kwindoweffects_x11.cpp > src/kselectionwatcher.h > > Diff: https://git.reviewboard.kde.org/r/124212/diff/ > > > Testing > ------- > > compiles, installs and autotest pass on platform Linux/xcb > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
