> On July 15, 2015, 8:49 p.m., Rohan Garg wrote: > > Ship It!
Compiles fine on my board, tests run fine too. - Rohan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review82543 ----------------------------------------------------------- On June 22, 2015, 10:43 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124150/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 10:43 p.m.) > > > Review request for KDE Frameworks and Rohan Garg. > > > Repository: kcoreaddons > > > Description > ------- > > Tries to address the issue pointed out by Rohan. > > We have a set of reverse-engineered literals and one of them we're specifying > it as unsigned (the rest are smaller, so it doesn't make a difference), even > though the API returns a signed int. > > > Diffs > ----- > > src/lib/io/kfilesystemtype.cpp e4043e4 > > Diff: https://git.reviewboard.kde.org/r/124150/diff/ > > > Testing > ------- > > Still compiles in the comfortable amd64+g++. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel