----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review82825 -----------------------------------------------------------
src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 60) <https://git.reviewboard.kde.org/r/124147/#comment57143> can be written more shortly with QFile kcookieBogusFile(kcookiejarDirName). same further down. src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 63) <https://git.reviewboard.kde.org/r/124147/#comment57144> use i18n() around user-visible strings (both the title and the text) src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 68) <https://git.reviewboard.kde.org/r/124147/#comment57147> mkdir returns a bool, why not check that, rather than re-check afterwards? This requires an early return after the above messagebox though, to avoid hitting the error here when it's a file instead of a dir. src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 71) <https://git.reviewboard.kde.org/r/124147/#comment57145> missing i18n() too src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 116) <https://git.reviewboard.kde.org/r/124147/#comment57146> I thought we established that no further checking is needed, better to work with a correct path in any case? ---> remove the comment? - David Faure On July 22, 2015, 10:59 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124147/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 10:59 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Prevents a cold start bug when the data dir is not created. Also, by > storing the file name as a member of the KCookieServer class we avoid > calculating it every time cookies are saved. > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/kcookieserver.h > f61c7d0e4da58b805565632cf3dd484445c21275 > src/ioslaves/http/kcookiejar/kcookieserver.cpp > ac585a0b04637c485647564d18a89a75d6c11d97 > > Diff: https://git.reviewboard.kde.org/r/124147/diff/ > > > Testing > ------- > > Restarted kded5 with no file named kcookiejar inside ~/.local/share and with > a regular file named kcookiejar in that location. > > In my setup, the message box is not showing properly but I am not sure if > this is somethign that happens only on my computer or if this is something > wrong with the code, can somebody confirm? > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
