----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124557/#review83241 -----------------------------------------------------------
Ship it! lgtm src/kshortcutseditor.cpp (line 603) <https://git.reviewboard.kde.org/r/124557/#comment57478> should this variable and the one above be renamed to actionId then? - Milian Wolff On July 31, 2015, 3:37 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124557/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 3:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > Only modify the shortcuts if they're specified on the file. > Use proper variable locality. > Get the configuration key correctly, as exported: Use Id instead of Name. > > > Diffs > ----- > > src/kshortcutseditor.cpp 9b1f42a > > Diff: https://git.reviewboard.kde.org/r/124557/diff/ > > > Testing > ------- > > I added an import feature, see further patch. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel