> On July 31, 2015, 8:18 a.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > <https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20> > > > > no-op?
Not a no-op, this code is written into cmake_install which is used for the 'install' target. If I don't add this line I get this during 'make install': ``` (...) -- Installing: Z:/kderoot/build/frameworks/kdoctools/image-msvc2015-RelWithDebInfo-master/kderoot/share/man/man7/qt5options.7 -- Found Perl: Z:/kderoot/dev-utils/bin/perl.exe (found version "5.20.2") CMake Error at Z:/kderoot/download/git/kdoctools/cmake/uriencode.cmake:34 (find_package): By not providing "FindPerlModules.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "PerlModules", but CMake did not find one. ``` (I can also push this separately) - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 ----------------------------------------------------------- On July 31, 2015, 7:34 a.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124542/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 7:34 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > BUG: 348061 > > > Diffs > ----- > > cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 > src/CMakeLists.txt e3868fc4f22324d25f680c13609bfb92b8b7c41d > > Diff: https://git.reviewboard.kde.org/r/124542/diff/ > > > Testing > ------- > > Adding ':' to the list of escaped characters is probably not an ideal > solution, but let me hear your ideas. > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel