> On Aug. 16, 2015, 9:20 a.m., Alex Merry wrote: > > Looks good, but there's a couple of debugging lines you've left in that > > should be removed.
Woa thanks for pointing out the debug lines .... It shows again that everything should be reviewed. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124736/#review83860 ----------------------------------------------------------- On Aug. 14, 2015, 1:29 p.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124736/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 1:29 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kapidox > > > Description > ------- > > We have to call python with native Windows paths. > We need to remove existing files before we replace them with os.rename as > windows raises an error if the file already exists, see > https://docs.python.org/2/library/os.html#os.rename . > > > Diffs > ----- > > CMakeLists.txt c1c5e2fe98d95f7a9afd0a7ebf951febdd03961f > src/kapidox/generator.py 39c14e29c8f9d35709ca7a912a3b5b9cc456a0e6 > > Diff: https://git.reviewboard.kde.org/r/124736/diff/ > > > Testing > ------- > > Windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel