> On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: > > Still runs kbuildsycoca5 for me(?) > > > > ``` > > [3796] kf5.kservice.sycoca: Trying to open ksycoca from > > "C:/Users/kfunk/AppData/Local/cache/ksycoca5" > > [3796] checking file timestamps > > [3796] timestamps check ok > > [3796] Emitting notifyDatabaseChanged () > > [4824] kf5.kinit.klauncher: kbuildsycoca5 running... > > [4824] > > [4824] kf5.kinit.klauncher: process finished exitcode= 0 exitStatus= 0 > > [5668] kf5.kservice.sycoca: Trying to open ksycoca from > > "C:/Users/kfunk/AppData/Local/cache/ksycoca5" > > ``` > > > > ^ Check says "ok" but then still > > Kevin Funk wrote: > ... runs kbuildsycoca5?
Running kbuildsycoca5 is exactly expected (unless no files changed since last time). What this patch does is only step 1: no longer starting kded5. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84269 ----------------------------------------------------------- On Aug. 22, 2015, 10:45 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124876/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 10:45 a.m.) > > > Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa. > > > Repository: kservice > > > Description > ------- > > If 1.5s have passed since the last time we checked, we compare the mtime of > the directories (12 dirs on my system) with the timestamp stored in the > ksycoca database (which indicates that all changes prior to that time > are in the DB). > > Note that we only check the mtime of dirs, not files. Therefore manually > editing an installed .desktop file will require touching the dir, or > running kbuildsycoca5. > > > Diffs > ----- > > src/sycoca/ksycoca.cpp b7f7abc88db90d784851d91036069e0647fdcbf6 > src/sycoca/ksycoca_p.h 9f403d6f4be2b406f4985f668176cfa56a5898ea > > Diff: https://git.reviewboard.kde.org/r/124876/diff/ > > > Testing > ------- > > the kservice unittests still pass > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel