----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125290/#review85675 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Sept. 19, 2015, 5:14 p.m., Bartosz Sławianowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125290/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2015, 5:14 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > We need to process events in Qt event loop before querying Solid's device > list. Solid caches devices and relies on signals to refresh them (at the very > least that's how fstab backend works) which is a problem if kio_trash process > is reused. > > Currently if kio_trash process is reused and there were some device changes > (for example new NFS share was mounted) kio_trash will fail to choose valid > trash directory for "trashing" file - or fail to find all trash directories > (in case of list action). Next reuse of the same process would actually > succeed because TrashImpl::move (which is called later in the process of > trashing file) enters the loop. > > > Diffs > ----- > > src/ioslaves/trash/trashimpl.cpp 5a2832a > src/ioslaves/trash/trashimpl.h 9881d8e > > Diff: https://git.reviewboard.kde.org/r/125290/diff/ > > > Testing > ------- > > Arch Linux > > > Thanks, > > Bartosz Sławianowski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
