----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ -----------------------------------------------------------
(Updated Oct. 2, 2015, 12:59 p.m.) Review request for KDE Frameworks. Changes ------- - use a static array for location->icon mapping order - establish order home > desktop > documents > * causing the respective icons to override any other icons that might match a path - merge directory icon lookups into one conditional branching into another conditional for .directory (requires mounting, standardpath icon lookup does not) Bugs: 352498 https://bugs.kde.org/show_bug.cgi?id=352498 Repository: kio Description ------- this acts as an additional fallback to mimetype iconing and .directory overrides. xdg user dirs are relocatable and can change depending on user locale as well as user configuration and additionally are used in a range of different desktop environments making this a very runtime sort of decision. BUG: 352498 Diffs (updated) ----- autotests/kfileitemtest.h 615324f2b45fdc90a7841bdd0c8aa7f47cdf57a2 autotests/kfileitemtest.cpp 5f728a411401fe3009924b66970d9ae6f12c60f2 src/core/kfileitem.cpp 966d8626708a8f2672f1777c873f4e27e13023d6 Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing ------- maked autotested installed dolphin and file open dialogs now show icons Thanks, Harald Sitter
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel