> On Oct. 2, 2015, 10:35 p.m., David Faure wrote: > > Sending Activate to a running Unique process is not a failure, so > > NoExitOnFailure should not affect it. > > > > If you need a "no exit, ever" flag, then I would recommend adding a > > separate flag for that. I'm not sure I understand the use case though.
In terms of the this code, the "failure" is "!d->registered" (see line 147 or 153 with this patch), so it is a failure to register the service (this is also supported by the docs saying "Indicates that the application should not exit if it failed to register with D-Bus."). So even if it sends Activate, it still failed to register the service and therefore the NoExitOnFailure should apply. No? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125483/#review86249 ----------------------------------------------------------- On Oct. 2, 2015, 7:52 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125483/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 7:52 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kdbusaddons > > > Description > ------- > > If KDBusService fails to register Unique service because other instance is > already running and if the user specified NoExitOnFailure, don't exit after > calling "Activate" on the other instance. > > > Diffs > ----- > > src/kdbusservice.cpp ea7727d > > Diff: https://git.reviewboard.kde.org/r/125483/diff/ > > > Testing > ------- > > App no longer exits and can do some other tasks like calling a different dbus > method to eg. pass data and then exit on its own. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
